Skip to content

Display pokemon's name in terminal title bar #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Display pokemon's name in terminal title bar #148

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
586c00d
specify pokemon name in terminal title bar
jimmyorourke Mar 24, 2018
cffde2b
refactor all terminal related changes into scripter.py
jimmyorourke Mar 24, 2018
1880e70
dont mix hex and decimal for differenct commands
jimmyorourke Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pokemonterminal/scripter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def __init_wallpaper_provider():

def clear_terminal():
# clear any updates to the terminal window's title bar
sys.stdout.write("\x1b]2;\x07")
sys.stdout.write("\033]2;\007")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is octal, not decimal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol true 😛 I can amend the commit message if that's something we really care about

__init_terminal_provider()
TERMINAL_PROVIDER.clear()

Expand All @@ -86,7 +86,7 @@ def change_terminal(image_file_path, title, background_process):
if background_process:
subprocess.run(['echo','-n', '\033]2;{}\007'.format(title)])
else:
sys.stdout.write("\x1b]2;{}\x07".format(title))
sys.stdout.write("\033]2;{}\007".format(title))
__init_terminal_provider()
TERMINAL_PROVIDER.change_terminal(image_file_path)

Expand Down