-
Notifications
You must be signed in to change notification settings - Fork 4
Skip multiprocessing if no callback actions requested; Add sound param; Fix signal handling #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michelcrypt4d4mus
wants to merge
24
commits into
Jorricks:main
Choose a base branch
from
michelcrypt4d4mus:add_sound_param_dealloc_class_better
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1d29cd5
MACOS_NOTIFICATIONS_AS_DAEMON constant; don't instantiate SimpleQueue…
5b2ed58
undo unnecessary changes
9a1033b
Don't register SIGINT handler when MACOS_NOTIFICATIONS_AS_DAEMON is true
ccb0b19
sound param
3246df9
Fix
a840d67
Merge branch 'main' into add_sound_param
5a1cbc2
soundName
cb39233
docs
f52f01b
Refactor out build_notification
064c642
Move classes
932dfc7
Reorg
428b569
comment
5b33a2e
remove autorelease_pool block comment
3140464
No need to return MacOSNotification object
cfb1101
comment
1278caa
comment
4edaaf1
comment
0127503
allow_multiprocessing arg
3254c0f
Allow SIGINT
fdda71c
remove env var
2cb0319
comments
55654ae
unused import
ae00c08
Put back the original signal handler before SIGINT raise
8d906cb
Remove NotificationProcess altogether
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jorricks why do you need both
atexit()
and customSIGINT
handling that do the exact same thing (callself.cleanup()
)? Seems like justatexit()
should be sufficient to accomplish what you are going for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly do not recall.
I think we can indeed remove the
catch_keyboard_interrupt
but let's save that for another MR.