Set up infrastructure to support different platform versions in single branch #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to me that it's easier to keep version-specific changes in branches, rather than try to keep sources this way. |
Of course, it's up to main plugin maintainers, but I have experience with branches in two plugins and in both cases the suggested approach requires much fewer actions because usually there are not so many incompatibilities in the platform |
|
There is not only platform. but also terminal plugin is used here, and, unfortunately, latter one does not seem very stable. |
It's a bundled plugin, so I think we can bravely consider it as a part of the platform anyway because the update cycle is the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And support 233 platform as an example