-
Couldn't load subscription status.
- Fork 444
fix: resolve frontend hydration error and handle log file permission issues #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
feat: update shell command execution for cross-platform compatibility
frontend/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zinzied Could you remove changes of yarn.lock file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've already added feature cancel so this code is duplicate. Please revert the changes.
| return " ".join(docker_parts) | ||
|
|
||
|
|
||
| class BashTool(LLMTool): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR! For running commands on Windows (cmd), I think it would be cleaner to separate the logic into a dedicated tool (e.g., CmdTool) rather than mixing it into the existing implementation.
In the future, when we add sandbox support, we'll only need to support Linux, so keeping the platforms decoupled now will make things easier to maintain.
Summary
This PR fixes two critical issues preventing the application from running properly:
Changes Made
Frontend Fix (
frontend/components/question-input.tsx)asChildprop toTooltipTriggercomponent to prevent nested button DOM structureBefore: