Assignment 1 #21
Open
Assignment 1 #21
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: PrincessBrideTrivia/PrincessBrideTrivia/Program.cs modified: PrincessBrideTrivia/PrincessBrideTrivia/Question.cs
modified: PrincessBrideTrivia/PrincessBrideTrivia.Tests/ProgramTests.cs
fixed unit tests to match new functionality
updated assertions to use HasCount
modified: PrincessBrideTrivia/PrincessBrideTrivia/Program.cs
fixed CalculateScore to return 0 for no correct answers and double casting
changed LoadQuestion to more easily define the size of question blocks from the text file
ColtonKnopik
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two main issues in a Princess Bride Trivia application as part of Assignment 1. The changes fix a crash in the application and ensure unit tests pass properly.
- Fixed division by zero error in percentage calculation method
- Corrected missing assignment of questions to array in LoadQuestions method
- Updated test file path generation to use proper temporary directory
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated assignment checklist to mark all requirements as completed |
| Question.cs | Added blank line for code formatting |
| Program.cs | Fixed GetPercentCorrect method and LoadQuestions array assignment bug |
| ProgramTests.cs | Fixed file path generation and array initialization syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged classmate suggestion
SummarySummary
CoveragePrincessBrideTrivia - 58.5%
|
Hellothereyoko
commented
Oct 3, 2025
Hellothereyoko
commented
Oct 3, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@nicoduvekot Waiting for your review |
There was a problem hiding this comment.
Assignment Details
- Pull Request title includes "Assignment 1" in the title ✔
- Partner has also made a commit ✔
- Pull Request targets Assignment 1 branch ✔
- Issue 1: Application no longer crashes ✔
- Issue 2: Unit test properly passes ✔
Extra Credit
- Come up with a new feature for the application
- Issue 3: Add a new feature request implemented ❌ Not implemented
- Issue 3: Feature request unit tested ❌ Not implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicoduvekot @Hellothereyoko