Assignment 1 #17

thigiang16 · 2025-09-29T22:03:41Z

I worked with @katmilton.
Extra credit: Added a new feature that lets players replay the quiz. After each round, they are asked if they want to play again, enter 'y' to play again and 'n' to quit

added comment explaining update to questions array

Removed unnecessary comment to better adhere to Guidelines

ColtonKnopik

Assignment Details

Pull Request title includes "Assignment 1" in the title ✔
Partner has also made a commit ✔
Pull Request targets Assignment 1 branch ✔
Issue 1: Application no longer crashes ✔
Issue 2: Unit test properly passes ✔

Extra Credit

Come up with a new feature for the application
    Issue 3: Add a new feature request implemented ✔
    Issue 3: Feature request unit tested ✔

Pull Request title should really include the space between "Assignment" and "1"

ColtonKnopik · 2025-09-30T05:27:43Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

+    public static bool ReplayQuiz()
+    {
+        Console.WriteLine("Play again? (y/n)");
+        string input = Console.ReadLine();
+        return input != null && input.Trim().ToLower() == "y";


Missing some kind of retry logic if the user does not enter a valid response. Consider if the users enters a key that is not 'y' or 'n', it should print some message saying "not valid response" and ask again.

Colton,

Thank you for your feedback. I have implemented your suggestion in our latest update to our PR. A message indicating the input is invalid will now display until a proper response is input by the user.

Copilot

Pull Request Overview

This PR adds a replay feature to the Princess Bride Trivia game, allowing players to play multiple rounds without restarting the application. It also fixes a bug in percentage calculation and includes a missing line in the question loading logic.

Added a do-while loop to enable quiz replay functionality
Fixed percentage calculation to handle division correctly and provide formatted output
Added missing assignment of questions to the array in LoadQuestions method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
PrincessBrideTrivia/Program.cs	Added ReplayQuiz method, wrapped main quiz logic in do-while loop, fixed percentage calculation, and added missing question assignment
PrincessBrideTrivia.Tests/ProgramTests.cs	Added unit tests for the new ReplayQuiz method covering both 'y' and 'n' inputs

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Updated replay quiz function to handle incorrect inputs

chanderlud

I was also thinking that randomizing the questions each time the user replays the quiz would be pretty cool too. Great work!

chanderlud · 2025-10-01T00:52:36Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

-            bool result = AskQuestion(questions[i]);
-            if (result)
+            Console.WriteLine("Play again? (y/n)");
+            string input = Console.ReadLine()?.Trim().ToLower();


Instead of using Console.ReadLine and treating the input as a string, the Console.ReadKey method could be used. This avoids the need for trimming and converting the user input to lowercase. It's also pretty cool because you don't need to press enter after hitting "y" or "n"

A minimal snippet using ReadKey, which can be dropped into the inside of your while true loop (you should add the "else" case with the invalid input warning message, though):

ConsoleKey key = Console.ReadKey(intercept: true).Key; if (key == ConsoleKey.Y) { Console.WriteLine("y"); return true; } if (key == ConsoleKey.N) { Console.WriteLine("n"); return false; }

Chander,

We did, in fact, have this in an earlier commit but ran into issues during unit testing.

#`while (true)

{ Console.WriteLine("Play again? (y/n)"); var key = Console.ReadKey(intercept: true).Key; Console.WriteLine(); if (key == ConsoleKey.Y) { return true; } else if (key == ConsoleKey.N) { return false; } else { Console.WriteLine("Invalid input. Please enter 'y' to play again or 'n' to quit."); } }`

I do think it is the better way to check for input, so we will probably head back to the drawing board for the unit test so that we can put this back in the implementation. Thank you for your feedback.

I just worked on this and managed to make it work with Console.ReadKey. It comes with some unit testing challenges, but I figured out a way to handle the test so we can use this approach

chanderlud · 2025-10-01T00:56:12Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

            question.Answers[1] = answer2;
            question.Answers[2] = answer3;
            question.CorrectAnswerIndex = correctAnswerIndex;
+            questions[i] = question;


On my pull request, a reviewer suggested cleaning up the object initialization for Question

I found that this simplified object initialization style worked really well & made this part of the code more readable.

Chander,

I get a 404 error from your link, but I definitely see how many of the lines within this method can be combined and/or condensed. I'm going to do a bit of research on the type of initialization you mentioned and keep a better eye out for future assignments/projects for instances where I can use that.

github-actions · 2025-10-01T04:32:19Z

Summary


Generated on:	10/01/2025 - 04:32:17
Coverage date:	10/01/2025 - 04:32:15
Parser:	MultiReport (2x Cobertura)
Assemblies:	1
Classes:	2
Files:	2
Line coverage:	64.4% (58 of 90)
Covered lines:	58
Uncovered lines:	32
Coverable lines:	90
Total lines:	134
Branch coverage:	50% (9 of 18)
Covered branches:	9
Total branches:	18
Method coverage:	Feature is only available for sponsors
Tag:	33_18151450245

Coverage

PrincessBrideTrivia - 64.4%

Name	Line	Branch
PrincessBrideTrivia	64.4%	50%
PrincessBrideTrivia.Program	63.2%	50%
PrincessBrideTrivia.Question	100%

c-stanton

Looks good!

c-stanton · 2025-10-02T03:24:31Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

+            if (key == ConsoleKey.Y)
+            {
+                return true;
+            }
+            else if (key == ConsoleKey.N)
            {
-                numberCorrect++;
+                return false;
            }
+            else
+            {
+                Console.WriteLine("Invalid input. Please enter 'y' to play again or 'n' to quit.");
+            }


I like that y'all are reprompting the user for correct inputs. Nicely done!

c-stanton · 2025-10-02T03:25:27Z

Assignment Details

Pull Request title includes "Assignment 1" in the title ✔
Partner has also made a commit ✔
Pull Request targets Assignment 1 branch ✔
Issue 1: Application no longer crashes ✔
Issue 2: Unit test properly passes ✔

Extra Credit

Come up with a new feature for the application
    Issue 3: Add a new feature request implemented ✔
    Issue 3: Feature request unit tested ✔

I liked your test replay feature. Well done!

Joshua-Lester3

Assignment Details

Pull Request title includes "Assignment 1" in the title ✔
Partner has also made a commit ✔
Pull Request targets Assignment 1 branch ✔
Issue 1: Application no longer crashes ✔
Issue 2: Unit test properly passes ✔

Extra Credit

Come up with a new feature for the application
- Issue 3: Add a new feature request implemented ✔
- Issue 3: Feature request unit tested ✔

Joshua-Lester3 · 2025-10-06T23:13:31Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

-        Question[] questions = LoadQuestions(filePath);
+        do
+        {
+            Question[] questions = LoadQuestions(filePath);


Probably don't need to reload the questions upon every quiz retake.

Joshua-Lester3 · 2025-10-06T23:15:59Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

+            if (key == ConsoleKey.Y)
+            {
+                return true;
+            }
+            else if (key == ConsoleKey.N)
            {
-                numberCorrect++;
+                return false;
            }
+            else
+            {
+                Console.WriteLine("Invalid input. Please enter 'y' to play again or 'n' to quit.");
+            }


Could use a switch statement here (I'm not sure if we've gone over that yet - just wanted to make you aware! :) ).

Joshua-Lester3 · 2025-10-06T23:24:15Z

PrincessBrideTrivia/PrincessBrideTrivia/Program.cs

+    }
+
+
+    public static bool ReplayQuiz(Func<ConsoleKey> readKeyFunc = null)


This isn't something I think we've gone over in class (could be wrong), so I won't deduct points. Just wanted you to be aware:

Adding functionality for testing purposes is bad practice as far as I'm aware. Though it might be beyond where we currently are to test it properly. The approach that is probably closest to where the class is, is redirecting stdin/out. This documentation might help.

Joshua-Lester3 · 2025-10-06T23:28:03Z

@thigiang16 @katmilton Remember to respond to and resolve all peer review comments. Copilot's review too (though it didn't add any comments).

thigiang16 and others added 4 commits September 29, 2025 14:40

Fix cast to double before dividing

daeb23c

Fix cast to double before dividing

08764d1

assign question to array

c562461

add comment for questions array update

7b9059b

added comment explaining update to questions array

thigiang16 changed the base branch from main to Assignment1 September 29, 2025 22:07

thigiang16 and others added 3 commits September 29, 2025 15:18

Add a replay feature for the quiz

74ed690

remove unnecessary comment

64caf7a

Removed unnecessary comment to better adhere to Guidelines

Add 2 unit tests for replay feature

9e08494

ColtonKnopik reviewed Sep 30, 2025

View reviewed changes

BenjaminMichaelis requested a review from Copilot September 30, 2025 15:34

Copilot AI reviewed Sep 30, 2025

View reviewed changes

thigiang16 changed the title ~~Assignment1~~ Assignment 1 Sep 30, 2025

katmilton and others added 3 commits September 30, 2025 13:51

update replay quiz function

0fab942

Updated replay quiz function to handle incorrect inputs

remove unnecessary whitespace

9ad466b

Updated tests for Replay feature

f07fe9a

chanderlud reviewed Oct 1, 2025

View reviewed changes

Updated the replay feature and unit tests

54b9b3d

c-stanton reviewed Oct 2, 2025

View reviewed changes

Joshua-Lester3 reviewed Oct 6, 2025

View reviewed changes

		}


		public static bool ReplayQuiz(Func<ConsoleKey> readKeyFunc = null)

Assignment 1 #17

Are you sure you want to change the base?

Assignment 1 #17

Conversation

thigiang16 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ColtonKnopik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

chanderlud left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

#`while (true)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 1, 2025

Summary

Coverage

Uh oh!

c-stanton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c-stanton commented Oct 2, 2025

Uh oh!

Joshua-Lester3 left a comment

Choose a reason for hiding this comment

Assignment Details

Extra Credit

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Joshua-Lester3 commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thigiang16 commented Sep 29, 2025 •

edited

Loading