Use std::optional for heart rate #2342
Open
+39
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
If no value is available, use null. Use this distinction to differentiate in the UI between missing data and zero value. Still sends value 0 over BLE. I'm unsure whether this should change or not
|
Build size and comparison to main:
|
|
Checks have not completed because they require maintainer approval. This isn't something I can do anything about, I'm not sure what's the purpose of this warning. |
|
Building the simulator fails.
Is there an existing setup for this which I can use? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no value is available, use null. Use this distinction to differentiate in the UI between missing data and zero value.
Still sends value 0 over BLE. I'm unsure whether this should change or not