Dgdimitrov/refactoring #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Introduce BaseDto and BaseDb to centralize common properties and functionality.
-Refactor with BaseNorthwindAPIController to eliminate redundant code across controllers.
-Implement BaseDbService to streamline business logic and reduce repetition in controllers.
-Remove direct database interactions from controllers, delegating all logic to services.
-Remove database objects from tests, ensuring all logic is managed through services for better testability.
When AB is ready, we will update all DTOs to have internal setters for IDs and pass the ID via query parameters for the PUT update method. The Update method in BaseDbService is already prepared for this change. I will submit a PR for this soon.