Skip to content

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 24, 2022

What do these changes do?

Adds support for python-based services and some extra fixes

  • .osparc/
    • 🐛 fixes on bin/ooils.bash: pull image if does not exists
    • bin/python_binder_program.py : new python binder for python-based "function services"
    • requirements.txt: dependencies for the latter
  • 📝 improves doc
  • ♻️ cookiecutter
    • cookiecutter.json changed defaults for Dockerfile
    • hooks/post_gen_project.py: cleans config for python image_base

Related issue/s

How to test

make devenv
source .venv/bin/activate
make play

Checklist

  • python Dockerfile: copy always .osparc and install requirements. add PATH=.osparc/bin . Implement CMD with binder
  • ooil as executable
    • bug with docker-compose-override.yml ... dockerfile: docker/python/Dockerfile does not work with docker compose
    • [ ]

@pcrespov pcrespov force-pushed the is3418/python_binder branch from cb33b41 to 6bdd5c9 Compare January 19, 2024 21:43
@pcrespov pcrespov modified the milestones: Watermelon, This is Sparta! Jan 22, 2024
@pcrespov pcrespov marked this pull request as ready for review January 22, 2024 18:21
@pcrespov pcrespov changed the title WIP: Is3418/python binder NEW Python binder Jan 22, 2024
@pcrespov pcrespov changed the title NEW Python binder ✨ NEW Python binder Jan 22, 2024
@pcrespov pcrespov changed the title ✨ NEW Python binder ✨ New Python binder for function-services Jan 22, 2024
@pcrespov pcrespov changed the title ✨ New Python binder for function-services ✨ New python binder for function-services Jan 22, 2024
@pcrespov pcrespov modified the milestones: This is Sparta!, Schoggilebe Feb 12, 2024
@pcrespov pcrespov removed this from the Schoggilebe milestone May 22, 2024
@JavierGOrdonnez
Copy link
Contributor

@pcrespov I believe this PR is no longer current - should we close it?

@pcrespov
Copy link
Member Author

pcrespov commented Mar 13, 2025

@pcrespov I believe this PR is no longer current - should we close it?

Hey @JavierGOrdonnez ! Just wondering if there’s a particular reason you’d like to close this? The functionality in this PR is super useful, even though it wasn’t fully finished. If it’s creating noise, I’m happy to close it—but otherwise, I’d prefer to keep it open so it’s easier for me to find later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants