Added DR Automation datasource and resources files #6428
Conversation
maniraj342
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, | ||
| "orch_standby_node_addition_status": &schema.Schema{ |
There was a problem hiding this comment.
why we have name like "orch_" when compare with others "orchestrator_"
Inconsistent naming convention?
| Required: true, | ||
| Description: "instance id of instance to provision.", | ||
| }, | ||
| "workspace_id": &schema.Schema{ |
There was a problem hiding this comment.
All arguments are required to call ValidatePowerVsWorkspaceOptions ?
User need's to provide workspace id, CRN,location_url?
| ForceNew: true, | ||
| Description: "instance id of instance to provision.", | ||
| }, | ||
| "stand_by_redeploy": &schema.Schema{ |
There was a problem hiding this comment.
This argument is n't boolean type?
| serviceInstanceFetchManageDrOptions := &drautomationservicev1.ServiceInstanceFetchManageDrOptions{} | ||
|
|
||
| parts, err := flex.SepIdParts(d.Id(), "/") | ||
| if err != nil { |
There was a problem hiding this comment.
In resource can we handle the scenario if a resource is deleted outside Terraform context can we set the ID to empty so future plan/apply can find diff and create new
| ValidateFunc: validate.InvokeValidator("ibm_pdr_managedr", "stand_by_redeploy"), | ||
| Description: "Flag to indicate if standby should be redeployed (must be \"true\" or \"false\").", | ||
| }, | ||
| "accept_language": &schema.Schema{ |
There was a problem hiding this comment.
Any change like this arguments is Force new ?
We don't have destroy what it happens when we change these fields like "accept_language" & "if_none_match"
| return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_pdr_managedr", "create", "parse-context").GetDiag() | ||
| } | ||
| serviceInstanceManageDrOptions.SetContext(contextModel) | ||
| serviceInstanceManageDrOptions.SetPlanID(d.Get("plan_id").(string)) |
There was a problem hiding this comment.
We don't have fields like "plan_id","service_id", "action", "parameters" in Schema
why we are doing d.Get?
| serviceInstanceValidateKeyOptions := &drautomationservicev1.ServiceInstanceValidateKeyOptions{} | ||
|
|
||
| serviceInstanceValidateKeyOptions.SetInstanceID(d.Get("instance_id").(string)) | ||
| serviceInstanceValidateKeyOptions.SetApiKey(d.Get("api_key").(string)) |
There was a problem hiding this comment.
We don't have this defined in Schema "api_key"
2 participants
Community Note
Relates OR Closes #0000
Output from acceptance testing: