Sort by points.numCollected in /:hexathonId/users #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds sorting functionality to the hexathon users endpoint to return users ordered by their collected points in descending order, with a secondary sort by name in ascending order. This change supports the implementation of a points leaderboard feature on the live site.
- Adds database query sorting by points.numCollected (descending) and name (ascending)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const offset = parseInt(req.query.offset as string) || 0; | ||
| const hexathonUsers = await HexathonUserModel.accessibleBy(req.ability) | ||
| .find(filter) | ||
| .sort({ "points.numCollected": 'desc', name: 'asc' }) |
There was a problem hiding this comment.
Consider adding a database index on points.numCollected and name fields to optimize this sorting operation, especially if this endpoint will be frequently accessed for leaderboard functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorts the db fetch by num points (descending) in the /:hexathonId/users route
todo: we can maybe make this contingent on a request param. This change is primarily for the points leaderboard on livesite.