Skip to content

Conversation

TheThanathor
Copy link
Member

@TheThanathor TheThanathor commented Aug 30, 2025

This PR makes Monsters Unbound no longer requires Survival Refightalized to work.

There should not be any changes in actual functionality of either module

@Bloo-dev Bloo-dev self-assigned this Sep 8, 2025
@Bloo-dev Bloo-dev added the quality-update Improves efficiency or structure without affecting functionality of a module label Sep 8, 2025
effect give @s[type=!#minecraft:undead] instant_health 1 20 true

# process any spawned mobs (uses sr instead of mu to be compatible with survival_refightalized)
execute if score $mob_extras gm4_sr_data matches 1.. unless entity @s[tag=gm4_sr_extra_mob] as @e[type=#gm4_monsters_unbound:modify,tag=gm4_sr_extra_mob] at @s run function gm4_monsters_unbound:mob/init/initialize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @e without any range restrictions here is pretty bad performance wise. Is it possible to somehow limit its scope?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, it needs to find mobs anywhere in the world to process them, that is why this only runs if SR is not installed

Fixes a bug where a resistance level over 4 might not be counted
- slowed health regeneration
- armor now regenerates even if health is not full
- fixed up the arrow damage function tag
@Bloo-dev Bloo-dev added the server-testing This is undergoing testing on the Public GM4 Server label Sep 23, 2025
@Bloo-dev Bloo-dev removed their assignment Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality-update Improves efficiency or structure without affecting functionality of a module server-testing This is undergoing testing on the Public GM4 Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants