-
-
Notifications
You must be signed in to change notification settings - Fork 61
Make Monsters Unbound standalone #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make Monsters Unbound standalone #1154
Conversation
effect give @s[type=!#minecraft:undead] instant_health 1 20 true | ||
|
||
# process any spawned mobs (uses sr instead of mu to be compatible with survival_refightalized) | ||
execute if score $mob_extras gm4_sr_data matches 1.. unless entity @s[tag=gm4_sr_extra_mob] as @e[type=#gm4_monsters_unbound:modify,tag=gm4_sr_extra_mob] at @s run function gm4_monsters_unbound:mob/init/initialize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @e
without any range restrictions here is pretty bad performance wise. Is it possible to somehow limit its scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, it needs to find mobs anywhere in the world to process them, that is why this only runs if SR is not installed
gm4_monsters_unbound/data/gm4_monsters_unbound/function/mob/init/elite/type/blazing.mcfunction
Show resolved
Hide resolved
...nsters_unbound/data/gm4_monsters_unbound/function/mob/init/mob_type/enderman/base.mcfunction
Show resolved
Hide resolved
Fixes a bug where a resistance level over 4 might not be counted
- slowed health regeneration - armor now regenerates even if health is not full - fixed up the arrow damage function tag
This PR makes Monsters Unbound no longer requires Survival Refightalized to work.
There should not be any changes in actual functionality of either module