Skip to content

Mcr/netcore allow http client #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mcr/netcore allow http client #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f68196
Update netcore.client.ftl
mark-robustelli Feb 28, 2024
6ee4e0c
Update netcore.client.sync.ftl
mark-robustelli Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/main/client/netcore.client.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,22 @@ namespace io.fusionauth {
return new DefaultRESTClient(host);
}
}

public class HttpClientBuilder : IRESTClientBuilder
{
public HttpClient HTTP_CLIENT;

public HttpClientBuilder(HttpClient httpClient)
{
HTTP_CLIENT = httpClient;
}

public IRESTClient build(string host)
{
if (HTTP_CLIENT.BaseAddress == null)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a host string is passed in, but the BaseAddress of the HTTP_CLIENT is already set, the parameter is effectively ignored. This might be an anti-pattern.

{
HTTP_CLIENT.BaseAddress = new Uri(host);
}
return new DefaultRESTClient(HTTP_CLIENT);
}
}
4 changes: 2 additions & 2 deletions src/main/client/netcore.client.sync.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ namespace io.fusionauth {
public class FusionAuthSyncClient : IFusionAuthSyncClient {
public readonly FusionAuthClient client;

public FusionAuthSyncClient(string apiKey, string host, string tenantId = null) {
client = new FusionAuthClient(apiKey, host, tenantId);
public FusionAuthSyncClient(string apiKey, string host, string tenantId = null, IRESTClientBuilder clientBuilder = null) {
client = new FusionAuthClient(apiKey, host, tenantId, clientBuilder);
}

/**
Expand Down