feature/Add DATABASE_SCHEMA support for PostgreSQL #5368
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoz-w
changed the title
HenryHengZJ
reviewed
Oct 28, 2025
| migrationsRun: false, | ||
| entities: Object.values(entities), | ||
| migrations: postgresMigrations, | ||
| migrationsTableName: 'migrations', |
There was a problem hiding this comment.
is this necessary? can we use the default table name instead of hardcoding migrations as the table name
There was a problem hiding this comment.
True, im just completing the change as it seems a bit more larger. And ill refactor it better.
Thanks for the comment
HenryHengZJ
reviewed
Oct 28, 2025
| }) | ||
| break | ||
| case 'postgres': | ||
| const dbSchema = process.env.DATABASE_SCHEMA |
There was a problem hiding this comment.
you need to wrap these in curly brackets if using const
|
also if you can give a couple of screenshots to make sure this works, that'd be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the DATABASE_SCHEMA environment variable. This allows users to specify a default schema when using a PostgreSQL database, which is necessary for multi-schema environments.