Chore/WorkspaceID Check #5228
Merged
Chore/WorkspaceID Check #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added validation to ensure `activeWorkspaceId` is present in user requests for all API key operations (get, create, update, import, delete). - Updated `getWorkspaceSearchOptions` and `getWorkspaceSearchOptionsFromReq` to throw an error if `workspaceId` is not provided. - Modified service methods to enforce `workspaceId` as a required parameter for database operations related to API keys.
…aces and services - Updated various interfaces to make `workspaceId` a mandatory field instead of optional. - Enhanced assistant and export-import service methods to require `workspaceId` for operations, ensuring proper validation and error handling. - Modified database entity definitions to reflect the change in `workspaceId` from optional to required. - Improved error handling in controllers to check for `activeWorkspaceId` before proceeding with requests.
- Updated controllers for credentials, datasets, document stores, evaluations, evaluators, and variables to enforce the presence of `workspaceId`. - Enhanced error handling to throw appropriate errors when `workspaceId` is not provided. - Modified service methods to accept `workspaceId` as a mandatory parameter for operations, ensuring consistent validation across the application.
… retrieval - Modified the runAdditionalEvaluators function to accept workspaceId as a parameter.
- Updated chatflow and flow-config controllers to require workspaceId for fetching chatflows. - Modified service methods to accept workspaceId as a parameter, ensuring proper context for chatflow retrieval.
Closed
0xi4o
approved these changes
Oct 2, 2025
- Enhanced permission checks in chatflows routes to include agentflows permissions for create, read, update, and delete operations. - Updated navigation paths in authentication views to redirect to the home page instead of chatflows after successful login or registration.
fix(DefaultRedirect.jsx): add redirect unauthenticated users to loginDescription
Result
|
fix(RequireAuth.jsx): check permissions for routes without display propertyDescriptionRedirect to Result
|
|
lgtm. |
vasunous
reviewed
Oct 14, 2025
| { path: '/login-activity', permission: 'loginActivity:view', display: 'feat:login-activity' }, | ||
| // Other routes | ||
| { path: '/logs', permission: 'logs:view', display: 'feat:logs' }, | ||
| { path: '/account', display: 'feat:account' } |
There was a problem hiding this comment.
Is this expected to not have any permission for /account?
There was a problem hiding this comment.
there is no specific account permission in Permissions.ts
fix(DefaultRedirect.jsx): WorkspaceSwitcher api spamDescriptionReplaced ResultBefore
After
|
…as-changed/:id/:lastUpdatedDateTime
Commits
DescriptionReplaced Result
|
…uest chatflow/:id
… in generateTextToSpeech
…l and validation using workspaceId
Commit
DescriptionImplementing proper workspace isolation. Result
|
…eleteCustomTemplate
chungyau97
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
Note: The following items will be addressed in separate PRs:
- Migration script for all DB platforms to make the
workspaceIdcolumn not null. - Implement granular permissions for the API Key.
- Generalize error handling in the UI to include error number codes along with friendlier error messages.
- Return the correct HTTP status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.