Last opened history mode show result icon instead

[jjw24]

Follow on with #4042

Before

After

[gitstream-cm]

🥷 Code experts: Jack251970

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher/Storage/LastOpenedHistoryItem.cs

Activity based on git-commit:

	Jack251970
OCT	38 additions & 7 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
Jack251970: 48%

Flow.Launcher/Storage/QueryHistory.cs

Activity based on git-commit:

	Jack251970
OCT	78 additions & 12 deletions
SEP
AUG
JUL
JUN
MAY

Knowledge based on git-blame:
Jack251970: 70%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	Jack251970
OCT	125 additions & 88 deletions
SEP	13 additions & 15 deletions
AUG
JUL	76 additions & 51 deletions
JUN	25 additions & 13 deletions
MAY	529 additions & 316 deletions

Knowledge based on git-blame:
Jack251970: 37%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[jjw24]

@Jack251970 @01Dri thoughts on showing the last opened with the actual result icon? Should it just show the icon instead of badge icon as well?

[jjw24]

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

[01Dri]

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

It’s not really a bug. The equality comparison also uses the query, so in scenarios where I type “Ter” and open Terminal, and then type “Term” and open Terminal again, I end up with two history items “Ter” and “Term” both referring to the same application (Terminal), which causes duplicate results.

In Query style, that makes sense because the two queries are different.
However, in Last Opened style, it doesn’t really make sense.
A suggestion would be to filter the history items, removing duplicates by name and sorting them by the most recent execution date/time.
Here’s an example in MainViewModels.cs -> GetHistoryItems:

    foreach (var h in historyItems
               .OrderByDescending(x => x.ExecutedDateTime) 
               .DistinctBy(x => x.GetCompositeKey()).ToList())

CompositeKey (This name is just an example; it could be something else)

   public string GetCompositeKey()
    {
        var parts = new[] { Title, SubTitle, RecordKey }
            .Where(s => !string.IsNullOrEmpty(s));

        return string.Join("-", parts);
    }

[01Dri]

@Jack251970 @01Dri thoughts on showing the last opened with the actual result icon? Should it just show the icon instead of badge icon as well?

I think the icon with the badge is more intuitive for the user, as it indicates that the item is a history entry.

[Jack251970]

Also, there is a bug in the comparison logic when saving history results because as seen in the screenshot 'Save Settings' result shouldn't be duplicated.

As 01Dri said, it is not a bug. Duplicated items will occur if you click A for many times.

[Jack251970]

Please check if h.IcoPath exists to prevent possible blank icon

[Jack251970]

result.IcoPath should be absolute path which depends on Flow installed place, plugin version, Flow portable mode, etc. I think here we should use the relative path:

If this icon is inside the directory of the preinstalled plugins, let us store a relative path based on preinstalled plugin directory.

Else if the icon is inside the directory of the Flow data directory, let us store a relative path based on Flow data directory.

Else let us just use the absolute path.

[Jack251970]

Showing icons enhance users' experience and I agree with this change. But there is still something we need to resolve

[jjw24]

@01Dri @Jack251970

I think the icon with the badge is more intuitive for the user, as it indicates that the item is a history entry.

What about just use the actual results icons, no badge?

However, in Last Opened style, it doesn’t really make sense.
A suggestion would be to filter the history items, removing duplicates by name and sorting them by the most recent execution date/time.

I think we should apply filtering of duplicates when last opened style is selected. What do you think?

[Jack251970]

I think we should apply filtering of duplicates when last opened style is selected. What do you think?

@jjw24 I think we can do the filtering here as long as we keep the history in the order of execute time so that we can utilize the history list more effectively.

[01Dri]

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

[Jack251970]

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

You can create PR to last_history_show_result_icon branch

[01Dri]

@Jack251970 @jjw24 Sorry for the question, I’m new to the open source community. My question is: am I allowed to make the requested changes, or is this PR only for jjw? Thanks!

You can create PR to last_history_show_result_icon branch

Ok thanks!

[jjw24]

@01Dri just to add, of course you can, just let the PR author know what/which area you are changing to avoid overlapping. If very minor like comments, typos or small corrections to the logic that you are sure won't overlap with what the author is doing then go ahead, otherwise its good to let the PR author know you intend to help out with certain areas of the PR.

Having said that, I am still making changes to this draft but help is very welcomed still.