-
Notifications
You must be signed in to change notification settings - Fork 152
Manifest file for new MS Outlook Integration #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Manifest file for new MS Outlook Integration
Hi @cibere , could you please review you when you get a chance, thanks! |
…5a1033-354c-4728-9334-e27848ac529f.json rename to add the json file extension
… to Microsoft Outlook-145a1033-354c-4728-9334-e27848ac529f.json PR Comments
Hi @cibere , thanks for the review, I have updated the PR with your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a bit to your plugin's readme explaining how to use the plugin.
All set : https://github.com/avinashlahel/Flow.Launcher.Plugin.MSOutlook/blob/main/README.md |
Hi @cibere , changes done, can you please have a look ? Thanks! |
Hi @avinashlahel, I couldn't get this working with my version of Outlook: I am getting error:
|
Hi @jjw24 , can you please try now. I have fixed the issue. |
Your "solution" doesn't actually solve the issue, and (in a way) makes it worse. Building/installing dependencies in the workflow and not having them be static in the repository is something that you should be doing. Anyways, as far as the actual issue is concerned, the problem is that your plugin is packaging a Unfortunately the only solution that I've found is to have the code check to see if the file is valid at the very start of the plugin's life, and if not, force reinstall the dependency using a temp pip instance to ensure the proper |
About the Plugin
A new plugin for MS Outlook Integration.
Currently shows a list of all upcoming Meetings and the meetings can be directly opened from Flow Launcher.
Will enhance in the further releases to incorporate more Outlook features