SOF-7687: change propery schema title (for TS types) #359
Conversation
| "name", | ||
| "values" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Should be outside structural/basis folder
| "allOf": [ | ||
| { | ||
| "$ref": "hubbard_v.json" | ||
| "$ref": "../../core/reusable/hubbard_parameters.json" |
There was a problem hiding this comment.
Let's add reusable inside properties_directory?
| } | ||
| ] | ||
| }, | ||
| "source": { |
There was a problem hiding this comment.
We could reuse source for meta and proto holders
There was a problem hiding this comment.
I'm not sure we need this structure for Meta and Proto holders, as they contain an empty source:
"source" : {
"info" : {
},
"type" : "exabyte"
}
And holder has:
"source" : {
"type" : "exabyte",
"info" : {
"jobId" : "HKPDxdJgGX5FrXLCy",
"unitId" : "f23e15fa1304b005d942d64c-2ba70021fabbc28cbfb7cee0"
}
}
| "type": "object", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../material.json" |
There was a problem hiding this comment.
Do we need to store material here too?
There was a problem hiding this comment.
Material exists in all in_relaxed properties in the production database
dist/js/example/property/base.json
Outdated
| "units": "kbar", | ||
| "value": -149.03 | ||
| "value": -149.03, | ||
| "repetition": 0 |
dist/js/example/property/base.json
Outdated
| "name": "pressure", | ||
| "units": "kbar", | ||
| "value": -149.03 | ||
| "value": -149.03, |
There was a problem hiding this comment.
the name of the file could be holder.json instead of base
| { | ||
| "type": "null" | ||
| } | ||
| ] |
| "legend": { | ||
| "description": "Legend of y Axis data series", | ||
| "minItems": 1, | ||
| "type": "array" |
There was a problem hiding this comment.
Don't we need legend anymore?
There was a problem hiding this comment.
Based on production databases, we need legend only for the density_of_states property. Even more, the legend is required in the density_of_states property. It is already properly defined in density_of_states.json, file so I just removed it from here.
- Add new coordinate condition schemas (cylinder, plane, sphere, triangular_prism) - Add hubbard_parameters schema and jupyter_notebook_endpoint property - Add final_structure and is_relaxed properties - Add boundary_conditions and workflow properties - Refactor property schemas: rename base.json to holder.json, add meta_holder and proto_holder - Remove exabyteml and related ML schemas - Update property schemas with required fields and improved validation - Add repetition field to property schemas - Improve band structure, phonon DOS, and other property schemas - Update workflow schemas with better input/output handling - Regenerate all Python models and TypeScript types - Update package dependencies
k0stik
force-pushed
the
chore/SOF-7687
branch
from
6b26a59 to
7a73793
Compare
| class Name657(Enum): | ||
| ======= | ||
| class Name573(Enum): | ||
| >>>>>>> 8664c20e94ca9d52fce78f266358a60c7d88fb37 |
There was a problem hiding this comment.
Somethins malfunctioned here - let's clean up the merge artifacts, pls.
| class Name804(Enum): | ||
| ======= | ||
| class Name717(Enum): | ||
| >>>>>>> 8664c20e94ca9d52fce78f266358a60c7d88fb37 |
| class Name739(Enum): | ||
| ======= | ||
| class Name653(Enum): | ||
| >>>>>>> 8664c20e94ca9d52fce78f266358a60c7d88fb37 |
| class Type75(Enum): | ||
| >>>>>>> 8664c20e94ca9d52fce78f266358a60c7d88fb37 |
New schemas:
schema/properties_directory/structural/basis/boundary_conditions.json
schema/properties_directory/structural/basis/predicted_properties.json
schema/property/holder.json
schema/property/meta_holder.json
schema/property/proto_holder.json