-
Notifications
You must be signed in to change notification settings - Fork 4
feature/SOF-7273 temp: add schemas for sc, slab and interface #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VsevolodX
wants to merge
6
commits into
dev
Choose a base branch
from
feature/SOF-7273
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f3b67d6
feat: add supercell schema
VsevolodX 3d96ee7
feat: add slab schema
VsevolodX ec3d271
feat: add interface schema
VsevolodX 329cb95
update: fix refs
VsevolodX 35a1632
chore: minor fix
VsevolodX 56125c6
update: description fixes
VsevolodX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
{ | ||
"$id": "interface", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"title": "Interface Schema", | ||
"type": "object", | ||
"allOf": [ | ||
{ | ||
"$ref": "../material.json" | ||
} | ||
], | ||
"properties": { | ||
"interface_config": { | ||
"type": "object", | ||
"properties": { | ||
"type": { | ||
"type": "string", | ||
"enum": ["interface"] | ||
}, | ||
"source": { | ||
"type": "object", | ||
"properties": { | ||
"slab1_config": { | ||
"$ref": "slab.json" | ||
}, | ||
"slab2_config": { | ||
"$ref": "slab.json" | ||
} | ||
} | ||
}, | ||
"interface_parameters": { | ||
"type": "object", | ||
"properties": { | ||
"distance_z": { | ||
"type": "number", | ||
"description": "Vertical distance between the two slabs." | ||
}, | ||
"shift_x": { | ||
"type": "number", | ||
"description": "Horizontal shift along the x-axis of the second slab with respect to the first slab." | ||
}, | ||
"shift_y": { | ||
"type": "number", | ||
"description": "Horizontal shift along the y-axis of the second slab with respect to the first slab." | ||
}, | ||
"vacuum": { | ||
"type": "number", | ||
"description": "Vacuum spacing added above the second slab." | ||
} | ||
} | ||
}, | ||
"derived_properties": { | ||
"type": "object", | ||
"properties": { | ||
"strain": { | ||
"type": "number", | ||
"description": "Strain of the second slab." | ||
}, | ||
"termination_pair": { | ||
"type": "string", | ||
"description": "Pair of terminations at the interface. Written as a tuple of two strings, e.g `('C_P6/mmm_2', 'Ni_R-3m_1')`" | ||
} | ||
} | ||
} | ||
}, | ||
"required": ["type", "source", "interface_parameters"] | ||
} | ||
}, | ||
"required": ["interface_config"] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
{ | ||
"$id": "slab", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"title": "Slab Schema", | ||
"type": "object", | ||
"allOf": [ | ||
{ | ||
"$ref": "../material.json" | ||
} | ||
], | ||
"properties": { | ||
"slab_config": { | ||
"type": "object", | ||
"properties": { | ||
"type": { | ||
"type": "string", | ||
"enum": ["slab"] | ||
}, | ||
"source": { | ||
"$ref": "../material.json" | ||
}, | ||
"slab_parameters": { | ||
"type": "object", | ||
"properties": { | ||
"miller_indices": { | ||
"type": "array", | ||
"items": { | ||
"type": "integer" | ||
}, | ||
"description": "Miller indices of the slab surface." | ||
}, | ||
"thickness": { | ||
"type": "integer", | ||
"description": "Thickness of the slab in layers." | ||
}, | ||
"vacuum": { | ||
"type": "number", | ||
"description": "Vacuum spacing added above the slab." | ||
}, | ||
"xy_supercell_matrix": { | ||
"type": "array", | ||
"items": { | ||
"type": "array", | ||
"items": { | ||
"type": "integer" | ||
} | ||
}, | ||
"description": "Matrix used for creating the xy supercell." | ||
}, | ||
"straining_matrix": { | ||
"type": "array", | ||
"items": { | ||
"type": "array", | ||
"items": { | ||
"type": "number" | ||
} | ||
}, | ||
"description": "Matrix used for straining the slab." | ||
}, | ||
"termination": { | ||
"type": "string", | ||
"description": "Termination of the slab surface. e.g. 'C_P6/mmm_2'" | ||
} | ||
} | ||
}, | ||
"derived_properties": { | ||
"type": "object", | ||
"properties": { | ||
"strain": { | ||
"type": "number", | ||
"description": "Mean absolute strain applied to the slab." | ||
}, | ||
"transformation_matrix": { | ||
"type": "array", | ||
"items": { | ||
"type": "array", | ||
"items": { | ||
"type": "number" | ||
} | ||
}, | ||
"description": "Matrix describing the slab transformation." | ||
} | ||
} | ||
} | ||
}, | ||
"required": ["type", "source", "slab_parameters"] | ||
} | ||
}, | ||
"required": ["slab_config"] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
{ | ||
"$id": "supercell", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"title": "Supercell Schema", | ||
"type": "object", | ||
"allOf": [ | ||
{ | ||
"$ref": "../material.json" | ||
} | ||
], | ||
"properties": { | ||
"supercell_config": { | ||
"type": "object", | ||
"properties": { | ||
"type": { | ||
"type": "string", | ||
"enum": ["supercell"] | ||
}, | ||
"source": { | ||
"$ref": "../material.json" | ||
}, | ||
"supercell_parameters": { | ||
"type": "object", | ||
"properties": { | ||
"supercell_matrix": { | ||
"type": "array", | ||
"items": { | ||
"type": "array", | ||
"items": { | ||
"type": "integer" | ||
} | ||
}, | ||
"description": "Matrix defining the supercell transformation." | ||
} | ||
} | ||
} | ||
}, | ||
"required": ["type", "source", "supercell_parameters"] | ||
} | ||
}, | ||
"required": ["supercell_config"] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we still need to refer to them as Substrate and Film, since this separation is used for straining