fix: change default collation allowance #170
Open
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make provision for C_COLLATION_OID and POSIX_COLLATION_OID which are also built-in types.
|
@Climax777 , Thanks for the patches. At a glance, changes looks good to me. However, I will have a deeper look into it. |
|
I found out that I will work in a bigger patch for normal top level Should I rather make a new pull request to keep things simple and clear? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make provision for C_COLLATION_OID and POSIX_COLLATION_OID, which are also built-in types.
I'm not 100% sure what the impact will be, but everywhere specifically DEFAULT_COLLATION_OID was used, the other two are allowed now as well.
This fixes #169 and pushes down ObjectID queries for all columns.