-
Notifications
You must be signed in to change notification settings - Fork 11
add -stable to path so the task doesn't fail #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the x-www-browser alternative in Ansible to point from /usr/bin/brave-browser to /usr/bin/brave-browser-stable. No other fields or logic changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
roles/workstation/tasks/packages.yml (1)
86-90: Approve — verify Brave binary & alternatives on target hosts
- Verification script produced no output; unable to confirm /usr/bin/brave-browser-stable or x-www-browser entries. Run on a representative host and paste the output:
#!/bin/bash set -euo pipefail command -v update-alternatives >/dev/null # Confirm binary exists if [[ -x /usr/bin/brave-browser-stable ]]; then echo "OK: /usr/bin/brave-browser-stable present" else echo "MISSING: /usr/bin/brave-browser-stable" && exit 1 fi # Show current x-www-browser alternatives update-alternatives --query x-www-browser || update-alternatives --display x-www-browser || true # Optional: confirm selection update-alternatives --list x-www-browser | sed 's/^/candidate: /'
- Optional hardening: set priority (e.g., 201) and register gnome-www-browser -> /usr/bin/brave-browser-stable to lock default.
Summary by CodeRabbit
New Features
Bug Fixes
Chores