Skip to content

Conversation

@thomasbeaudry
Copy link
Collaborator

@thomasbeaudry thomasbeaudry commented Sep 19, 2025

Summary by CodeRabbit

  • New Features

    • None.
  • Bug Fixes

    • Corrected default system browser mapping to use Brave Stable, ensuring links open in Brave as expected across applications.
  • Chores

    • Updated system alternative configuration to align with the current Brave Stable package naming, improving reliability without changing user workflows.

@coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2025

Walkthrough

Updated the x-www-browser alternative in Ansible to point from /usr/bin/brave-browser to /usr/bin/brave-browser-stable. No other fields or logic changed.

Changes

Cohort / File(s) Summary
Ansible workstation packages task
roles/workstation/tasks/packages.yml
Adjusted x-www-browser alternative target from /usr/bin/brave-browser to /usr/bin/brave-browser-stable; no other task changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A browser’s path, now steady and able,
From brave to brave-stable, neat on the table.
No loops to twist, no tasks to tangle,
Just a clean reroute, a subtle angle.
Clicks march on—default set, no fable.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "add -stable to path so the task doesn't fail" accurately and concisely summarizes the main change—updating the Brave binary path to include "-stable" to prevent the task from failing; it is specific and directly related to the modification in roles/workstation/tasks/packages.yml. This phrasing communicates the intent clearly to reviewers scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fixBraveDefault

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
roles/workstation/tasks/packages.yml (1)

86-90: Approve — verify Brave binary & alternatives on target hosts

  • Verification script produced no output; unable to confirm /usr/bin/brave-browser-stable or x-www-browser entries. Run on a representative host and paste the output:
#!/bin/bash
set -euo pipefail
command -v update-alternatives >/dev/null
# Confirm binary exists
if [[ -x /usr/bin/brave-browser-stable ]]; then
  echo "OK: /usr/bin/brave-browser-stable present"
else
  echo "MISSING: /usr/bin/brave-browser-stable" && exit 1
fi
# Show current x-www-browser alternatives
update-alternatives --query x-www-browser || update-alternatives --display x-www-browser || true
# Optional: confirm selection
update-alternatives --list x-www-browser | sed 's/^/candidate: /'
  • Optional hardening: set priority (e.g., 201) and register gnome-www-browser -> /usr/bin/brave-browser-stable to lock default.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e44ca67 and 2c51796.

📒 Files selected for processing (1)
  • roles/workstation/tasks/packages.yml (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant