[DC-1546] TDR Python Client - [PyPI] Address deprecation notice for 'data-repo-client' #2018
Conversation
rjohanek
requested review from
rushtong,
kevinmarete,
calypsomatic,
davidangb and
samanehsan
and removed request for
a team
There was a problem hiding this comment.
Do the various requirements.txt files also need an update, e.g. https://github.com/DataBiosphere/jade-data-repo/blob/develop/tools/setupResourceScripts/requirements.txt#L1 ?
Also, does this change the pypi url from https://pypi.org/project/data-repo-client/ to https://pypi.org/project/data_repo_client/ ? If so, check the comment at line 2
Good question. I'm not sure if this only changes the names going forward. But, I think we we update the names it will just require the new version so that seems like a good change.
Yes, good catch! I'll fix that |
|
Jira ticket: https://broadworkbench.atlassian.net/browse/DC-1546
Addresses
In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. The data-repo-client is incompatible with PEP 625 because it does not contain the normalized project name 'data_repo_client'.
Summary of changes
change name of python client to match PEP 625 naming convention
Testing Strategy
run publish python client on PR temporarily, see run: https://github.com/DataBiosphere/jade-data-repo/actions/runs/18102588627/job/51509100999 the run failed because this release already exists but the client was generated successfully and with the correct compliant name
"Uploading data_repo_client-2.321.0.tar.gz" - this name is compliant with PEP 625
Notification requirements
Once this goes into effect I will notify the TDR channel of this change