Improve R_RemapShader behavior #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this really be targeting master branch if a map relies on this bug? |
I think it's fine. Assuming UnvanquishedAssets/map-thunder_src.dpkdir#7 is merged, users will get the updated engine and fixed map at the same time. Those using an engine from master will suffer a minor visual bug (all 5 rods always have lightning). Everyone already suffered this bug for a number of years while shader remap entities were broken. |
illwieckz
approved these changes
Sep 9, 2025
- Don't log if the shader has been registered with those flags before - Log only once per each new flag combination
Make R_RemapShader handle shader registration flags correctly. For each version of the shader, register the replacement shader with a matching set of flags, instead of always using RSF_DEFAULT. Also this fixes a bug that when the replacement shader was not found, the 'defaulted' shader (one that was not found or failed parsing) was used for rendering. New behavior is to not change the replacement state. Note that Thunder has recently been relying on this bug - see UnvanquishedAssets/map-thunder_src.dpkdir#7
slipher
force-pushed
the
remapshader
branch
from
d0f6b76 to
5cfbcab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.