Potential soil evaporation adjusted too much for mulch evap #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit fixes the problem, but it has a big impact. - Should we keep it? (cherry picked from commit 7e54a28d368e5d86d01f3de60176b147913e4c6c)
|
@fabiooliveira72, thanks for the analyses. The results are mixed, some experiments are better, some worse. I think overall, the impacts are minimal and we should accept the bugfix. Not worth recalibrating anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the modified Suleiman-Ritchie model, I came across a bug in SPAM. Mulch evaporation is accounted for twice and reduces soil evaporation too much. This commit fixes the problem. It does have an impact on some experiments:
It is a bug, but minor. We should probably fix it but need to thoroughly assess impact.