Ozone updates for CERES-Maize, CERES-Rice, CROPGRO-Soybean, NWheat, and Teff. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ECO (which was not used).
…ERES-Maize, CERES-Rice, and COPGRO-Soybean. Cleaned ozone loop in NWheat.
…from .SPE to .ECO for CERES-Maize and CROPGRO-Soybean. Moved ozone parameters from .SPE to .CUL for CERES-Rice. Also, added missing ECO parameter line in NWheat WH_PHENOL for consistency (missing line did not affect sims).
Ozone updates for CERES-Maize, CERES-Rice, CROPGRO-Soybean, NWheat and Teff
There was a problem hiding this comment.
Dr. Guarin!
Thanks for your contribution. Could you please re-test this branch and check if Ozone changes match exactly with your results.
You need to test with Ozone turned on and check if your results match and if they are correct. I did a change/Fix in ETPHOT.for that was affecting Forage crops with Ozone. Now they are only affecting with Ozone if it is turned on in simulation controls (DISES=O).
Please let me know if works then we can go ahead and merge this branch too.
Thank you.
Fabio Oliveira
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.