fix: panic on zero-length inputs in Mux #1600
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add explicit check in Mux to panic when inputs length is zero.
Prevents undefined behavior: previously n==0 led to bits.Len(n-1) on MaxUint and slicing inputs[:leftCount], causing non-obvious runtime panics and potential big.Int overflow in comparator bound construction.
Aligns with package style where invalid shape/size inputs trigger panic, while out-of-range selectors cause proof failure.
Type of change
How has this been tested?
go test -v ./std/selector
go test -v -run "Mux" ./std/selector
go test -v ./...
Checklist:
golangci-lint
does not output errors locally