[WIP] Persist all unsaved workflow tabs (make tabs behave like vscode) #6050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a little worried about giving the client more ownership over the workflow state - given future plans for possible CRDT (in particular, syncing when going offline->online) and some other features, but in general it should be fine. |
christian-byrne
added
area:workflows
claude-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP: keep all drafts in localstorage, try to mirror vscode logic.
Resolves Comfy-Org/desktop#910, Resolves #4057, Fixes #3665
┆Issue is synchronized with this Notion page by Unito