Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 12, 2025

Summary

Adds revamped system for widgets that have control after/before generate variant on them.

2025-10-12.15-25-48_processed_20251012_152642.mp4

TODO

  • fix step value being 10 (legacy system)
  • ensure it works with COMBO
  • ensure it works with FLOAT
  • ensure it works with primitive nodes
  • make "random option" selected by default
  • either implement or remove the config button functionality - think it should open settings?
  • align popover UI with design exactly

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/27/2025, 05:29:39 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/27/2025, 05:45:13 AM UTC

📈 Summary

  • Total Tests: 483
  • Passed: 434 ✅
  • Failed: 18 ❌
  • Flaky: 1 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 425 / ❌ 18 / ⚠️ 1 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne added the claude-review Add to trigger a PR code review from Claude Code label Oct 19, 2025
@christian-byrne christian-byrne force-pushed the vue-nodes/control-after-generate branch from 0a22f6c to 21bee63 Compare October 26, 2025 02:25
@christian-byrne christian-byrne force-pushed the vue-nodes/control-after-generate branch from 21bee63 to 90e6fc9 Compare October 26, 2025 09:04
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

Bundle Size Report

Summary

  • Raw size: 12.3 MB baseline 12.2 MB — 🔴 +21.9 kB
  • Gzip: 2.49 MB baseline 2.48 MB — 🔴 +5.43 kB
  • Brotli: 1.96 MB baseline 1.96 MB — 🔴 +3.96 kB
  • Bundles: 57 current • 56 baseline • 13 added / 12 removed

Category Glance
App Entry Points 🔴 +12.9 kB (3.31 MB) · Other 🔴 +8.33 kB (2.56 MB) · Graph Workspace 🔴 +620 B (722 kB) · Vendor & Third-Party ⚪ 0 B (5.36 MB) · Panels & Settings ⚪ 0 B (294 kB) · UI Components ⚪ 0 B (12.3 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.31 MB (baseline 3.29 MB) • 🔴 +12.9 kB

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-yeNfmkqK.js (new) 2.69 MB 🔴 +2.69 MB 🔴 +559 kB 🔴 +423 kB
assets/index-Be1LV_18.js (removed) 2.68 MB 🟢 -2.68 MB 🟢 -556 kB 🟢 -421 kB
assets/index-DBOcqxHz.js (removed) 618 kB 🟢 -618 kB 🟢 -114 kB 🟢 -90.5 kB
assets/index-G30tHAFC.js (new) 618 kB 🔴 +618 kB 🔴 +114 kB 🔴 +90.5 kB

Status: 2 added / 2 removed

Graph Workspace — 722 kB (baseline 721 kB) • 🔴 +620 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DbXfJOsG.js (new) 722 kB 🔴 +722 kB 🔴 +141 kB 🔴 +109 kB
assets/GraphView-TrPMGz0X.js (removed) 721 kB 🟢 -721 kB 🟢 -141 kB 🟢 -109 kB

Status: 1 added / 1 removed

Views & Navigation — 8.15 kB (baseline 8.15 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-BIoJzQhV.js (new) 8.15 kB 🔴 +8.15 kB 🔴 +2.47 kB 🔴 +2.15 kB
assets/UserSelectView-mdr_wDQo.js (removed) 8.15 kB 🟢 -8.15 kB 🟢 -2.47 kB 🟢 -2.15 kB

Status: 1 added / 1 removed

Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CreditsPanel-B5u0dtd8.js (removed) 22.1 kB 🟢 -22.1 kB 🟢 -5.28 kB 🟢 -4.61 kB
assets/CreditsPanel-CehbjGcc.js (new) 22.1 kB 🔴 +22.1 kB 🔴 +5.28 kB 🔴 +4.6 kB
assets/KeybindingPanel-d6t1mo1U.js (new) 15.2 kB 🔴 +15.2 kB 🔴 +3.76 kB 🔴 +3.31 kB
assets/KeybindingPanel-TthUSm63.js (removed) 15.2 kB 🟢 -15.2 kB 🟢 -3.76 kB 🟢 -3.31 kB
assets/ExtensionPanel-BhuBkgCV.js (new) 12.1 kB 🔴 +12.1 kB 🔴 +2.83 kB 🔴 +2.48 kB
assets/ExtensionPanel-hNkvUbvO.js (removed) 12.1 kB 🟢 -12.1 kB 🟢 -2.83 kB 🟢 -2.48 kB
assets/AboutPanel-BbRDicDN.js (new) 10.3 kB 🔴 +10.3 kB 🔴 +2.66 kB 🔴 +2.35 kB
assets/AboutPanel-CrY7ekl5.js (removed) 10.3 kB 🟢 -10.3 kB 🟢 -2.66 kB 🟢 -2.35 kB
assets/ServerConfigPanel-D8GR9e0p.js (new) 8.2 kB 🔴 +8.2 kB 🔴 +2.17 kB 🔴 +1.89 kB
assets/ServerConfigPanel-TXcVxX4H.js (removed) 8.2 kB 🟢 -8.2 kB 🟢 -2.17 kB 🟢 -1.9 kB
assets/UserPanel-DBaEVdM2.js (new) 7.91 kB 🔴 +7.91 kB 🔴 +2.06 kB 🔴 +1.79 kB
assets/UserPanel-u7jsuFme.js (removed) 7.91 kB 🟢 -7.91 kB 🟢 -2.06 kB 🟢 -1.79 kB
assets/settings-B-df0dZe.js 20.7 kB 20.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CI6OKvJn.js 22.9 kB 22.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CXGVj_nD.js 24.5 kB 24.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DfQ6dSJj.js 31.6 kB 31.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DJ2QgDzm.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRNLPMG6.js 23.7 kB 23.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DVVycxDc.js 19.9 kB 19.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-G6Dybj1b.js 24.1 kB 24.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-M6_GZccG.js 26 kB 26 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-BSJorB8F.js (new) 11.1 kB 🔴 +11.1 kB 🔴 +2.76 kB 🔴 +2.44 kB
assets/ComfyQueueButton-CgAlJ6vB.js (removed) 11.1 kB 🟢 -11.1 kB 🟢 -2.76 kB 🟢 -2.44 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 1.12 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-Bw51cYUB.js (new) 7.21 kB 🔴 +7.21 kB 🔴 +1.75 kB 🔴 +1.5 kB
assets/keybindingService-u8LMxNPN.js (removed) 7.21 kB 🟢 -7.21 kB 🟢 -1.74 kB 🟢 -1.5 kB
assets/serverConfigStore-CvX_HMTJ.js 2.79 kB 2.79 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 1.07 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-EuL9bHKm.js 3.22 MB 3.22 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-PESgPnbc.js 517 B 517 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-DY0_3CMM.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-visualization-BEfdbjRw.js 1.82 MB 1.82 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-Di9L6lvm.js 92.4 kB 92.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 2.56 MB (baseline 2.55 MB) • 🔴 +8.33 kB

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/NumberControlPopover-0OVoL31M.js (new) 8.33 kB 🔴 +8.33 kB 🔴 +2.26 kB 🔴 +1.98 kB
assets/commands-B2KZRBmX.js 15.1 kB 15.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Bw-ckyga.js 13.9 kB 13.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C_NmM85I.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuozCW4W.js 14 kB 14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DGfVUJCR.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-dOJNDogK.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiE551e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Fw7mvqSy.js 13.1 kB 13.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-FXnO1W4Q.js 13.2 kB 13.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bgu6_Hvd.js 59.5 kB 59.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bv0L0qvp.js 93 kB 93 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C3Doz3n_.js 67.6 kB 67.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C7eBl607.js 70.7 kB 70.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CHiV9ds2.js 76.4 kB 76.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CIc79Nts.js 68.5 kB 68.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DK5LmuBm.js 58.8 kB 58.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-J1nit7cj.js 66.3 kB 66.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-W97XgvAQ.js 80.4 kB 80.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-8Ef8lY1m.js 196 kB 196 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BdF8EiZl.js 200 kB 200 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bv9Y8Cvp.js 229 kB 229 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-cMdB_wHv.js 179 kB 179 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvNWbbtX.js 194 kB 194 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CwDWxzVz.js 215 kB 215 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CyPAVHpA.js 191 kB 191 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D6QTD6bJ.js 181 kB 181 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DKn6VmRJ.js 192 kB 192 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added

@christian-byrne christian-byrne force-pushed the vue-nodes/control-after-generate branch 3 times, most recently from ff197a6 to 5252b49 Compare October 27, 2025 05:20
@christian-byrne christian-byrne force-pushed the vue-nodes/control-after-generate branch from 5252b49 to 1e0aa2c Compare October 27, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:vue-migration area:widgets claude-review Add to trigger a PR code review from Claude Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants