Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 12, 2025

Summary

Adds revamped system for widgets that have control after/before generate variant on them.

2025-10-12.15-25-48_processed_20251012_152642.mp4

TODO

  • fix step value being 10 (legacy system)
  • ensure it works with COMBO
  • ensure it works with FLOAT
  • ensure it works with primitive nodes
  • make "random option" selected by default
  • either implement or remove the config button functionality - think it should open settings?
  • align popover UI with design exactly

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/13/2025, 04:21:52 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 10/13/2025, 04:39:09 AM UTC

📈 Summary

  • Total Tests: 480
  • Passed: 430 ✅
  • Failed: 18 ❌
  • Flaky: 2 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 421 / ❌ 18 / ⚠️ 2 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

- Fix increment/decrement to use step2 (correct value) instead of legacy step (10x value)
- Add settings dialog integration to NumberControlPopover edit button
- Maintain backward compatibility for direct API usage and tests
- All 15 useNumberControl tests passing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@christian-byrne christian-byrne added the claude-review Add to trigger a PR code review from Claude Code label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:vue-migration area:widgets claude-review Add to trigger a PR code review from Claude Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant