Skip to content

Conversation

millerlight
Copy link

Thanks for the earlier security feedback.
In v1.0.0 I now strictly enforce a registry-backed whitelist:

POST /kvtools/peek only serves values for (file_name, key) that exist in kv_registry.json (basename-only, path traversal blocked via abspath().startswith(BASE_DIR)).

Image serving is scoped to the allowed root (optional extension whitelist), no arbitrary paths.

UI changes no longer trigger automatic runs.

In v1.0.0 I now strictly enforce a registry-backed whitelist:

    POST /kvtools/peek only serves values for (file_name, key) that exist in kv_registry.json (basename-only, path traversal blocked via abspath().startswith(BASE_DIR)).

    Image serving is scoped to the allowed root (optional extension whitelist), no arbitrary paths.

    UI changes no longer trigger automatic runs.
@ltdrdata
Copy link
Member

It is recommended to use folder_paths instead of getcwd.
Also, it is not recommended to place resource files inside the custom node directory.

https://github.com/millerlight/ComfyUI-KVTools/blob/608b468300f59bffc8f94550d08f55ca9335f451/kv_nodes.py#L178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants