optimize GetOutlineCameraFovAndDistanceFixMultiplier #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've attached some gifs for you to review ( notice the outline width ) |
|
Thank you! I will study this change and maybe merge the pull request directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some extreme conditions(eg. Very small FOV), the original GetOutlineCameraFovAndDistanceFixMultiplier will become too thin.
Also, the atan() function to get FOV is actually unnecessary in this use case. (Mutiplying outline width directly to FOV is not really correct to preserve line width)
I've included the math into the comments of the .hlsl file, please review this optimization, thank you!