Skip to content

Conversation

Bitto1070
Copy link
Contributor

@Bitto1070 Bitto1070 commented Sep 23, 2025

  • Moved the categories outside the "create" function to let them become accessible to other states when KeybindsOptions is imported;
    • Theoretically, this shouldn't cause any issues, as it's not replacing the current categories variable.
  • Added translation support to custom options;
    • It checks if the translation even exists first before translating, to not cause any issues with old options.xml files (hopefully).
  • custom options menus are now tagged with a "custom: true", like their settings;
    • Really only used to check if it should add the "KeybindsOptions." prefix before translating. Might be useful to someone else, though.
      • oh yeah i also kinda removed that prefix from the translate function so people aren't forced to use it on their options.xml if they want to add translation support
  • also makes isSubstate public

@HeroEyad
Copy link
Member

this is very good, i like this.

@HeroEyad
Copy link
Member

@NexIsDumb thoughts?

@Raltyro Raltyro requested review from NexIsDumb and FuroYT October 4, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants