Skip to content

Conversation

Lior-Preminger
Copy link
Collaborator

  • Removed max_gate_count field from 60 JSON files across the library
  • Affects algorithms, applications, functions, and tutorials directories
  • Field was present as empty object {} in constraints section
  • Other constraint fields (max_width, optimization_parameter) preserved
  • JSON structure remains valid after removal

Resolves CLS-4163

PR Description

Some notes

  • Please make sure that the notebook runs successfully with the latest Classiq version.

  • Please make sure that you placed the files in an appropriate folder

    • And that the file names are clear, descriptive, and match the notebook content.
      • Note that we require the file names of .ipynb and .qmod to be unique across this repository.
    • Plus, please make sure that all required files are included: .qmod, .synthesis_options.json, .metadata.json
    • And that images are embedded inside the notebook, not added as external files
  • If applicable, please include link to the paper on which the notebook is based, in the notebook itself.

  • Please use rebase on your branch (no merge commits)

  • Please link this PR to the relevant issue

  • Please make sure to run pre-commit when commiting changes

    • If you're using git in the terminal, make sure to install pre-commit via running pip install pre-commit followed by pre-commit install
    • Note that Classiq runs automatic code linting. Meaning that one of the tests verifies the output of pre-commit.
    • Also note that pre-commit may minorly alter some files. Make sure to git add the changes done by pre-commit

@Lior-Preminger Lior-Preminger force-pushed the CLS-4163-removing-max-gate-count-from-classiq-library branch 4 times, most recently from 5c36cc7 to 897e495 Compare September 28, 2025 10:06
- Removed max_gate_count field from 60 JSON files across the library
- Affects algorithms, applications, functions, and tutorials directories
- Field was present as empty object {} in constraints section
- Other constraint fields (max_width, optimization_parameter) preserved
- All other fields (optimization_level, random_seed, basis_gates order) unchanged
- JSON structure remains valid after removal

Resolves CLS-4163
@Lior-Preminger Lior-Preminger force-pushed the CLS-4163-removing-max-gate-count-from-classiq-library branch from 897e495 to 76cd4fe Compare September 28, 2025 10:09
@Lior-Preminger Lior-Preminger merged commit 24de94c into main Sep 29, 2025
6 checks passed
@Lior-Preminger Lior-Preminger deleted the CLS-4163-removing-max-gate-count-from-classiq-library branch September 29, 2025 13:59
Copy link

🎊 You're on fire, @Lior-Preminger! Three PRs merged and counting! 🔥🎉

Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖
Have you considered taking on some more challenging issues? We'd love to see what you can do! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants