Integration testing with Testcontainers #294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project would benefit greatly from using Testcontainers to reliably provision ephemeral backend servers for integration testing. This makes it quick and easy to run integration tests against real servers running locally in Docker without the hassle of creating cloud accounts and managing credentials, etc.
This PR duplicates the two existing
vfsintegrationtest suites and modifies them to run their tests against the following local Docker containers:I've created this sub-module in a folder called "testcontainers" but happy to rename/move.
I've included two backends for S3 since both are quite popular and it's easy enough to test both.
All containers are created using the latest image versions, but there's no reason why they couldn't be pinned to one or more specific versions if needed.
Currently 15 of 340 tests are failing due to bugs/inconsistencies in certain backends. These should be fixed before this PR is merged.