Skip to content

Conversation

@ThisaraWeerakoon
Copy link
Contributor

Fixes #163

Add Stat() method to File interface.
Add Open() method to Location interface
Add Mocks for testing
Implementation for each backend

@c2fo-cibot c2fo-cibot bot added the size/XL Denotes a PR that changes 500-999 lines label May 11, 2025
@c2fo-cibot c2fo-cibot bot added size/XXL Denotes a PR that changes 1000+ lines and removed size/XL Denotes a PR that changes 500-999 lines labels May 11, 2025
@ThisaraWeerakoon
Copy link
Contributor Author

Hi @funkyshu
Would you have some time to review this PR? Your feedback would be greatly appreciated. Thank you!

@funkyshu
Copy link
Member

@ThisaraWeerakoon,
Thanks for this awesome contributions. In this case, I'm not 100% We actually want this as part of vfs (yes, I'm keenly aware that I added the feature request). The current interface is quite bloated already and while I love the idea of being compliant with a std interface, I don't love the ever-growing composition in io.FS (readdir, readfile, sub, etc). Have said all of that, I look forward to looking at your implementation across the various backends. As stated elsewhere, time is not on my side at the moment but I'll try to get to this in the next couple of weeks. Thanks again for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update vfs to implement io/fs's fs.FS interface

2 participants