Skip to content

Conversation

olesho
Copy link
Collaborator

@olesho olesho commented Sep 11, 2025

No description provided.

@olesho olesho requested a review from tysonthomas9 September 11, 2025 01:01
Copy link

coderabbitai bot commented Sep 11, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@olesho olesho changed the title DRAFT: Feat/OpenAI compatible api Feat/OpenAI compatible api Sep 11, 2025
@olesho olesho changed the title Feat/OpenAI compatible api DRAFT: Feat/OpenAI compatible api Sep 11, 2025
- Simple Dockerfile that uses pre-built local files
- Uses nginx:alpine for lightweight serving
- Designed for local development workflows
@tysonthomas9
Copy link
Collaborator

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 466 to +469
toolResult = await this.executeToolWithTimeout(
tool,
params.input,
params.timeout || 30000,
params.timeout || 2700000,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Correct chat/tool default timeouts

The new default timeout constant is 2700000, which equals 45 minutes, while the comment explicitly states “Default 15 minutes for chat” and the tool branch previously defaulted to 30 seconds. This multiplication by 90× means a failed or hanging evaluation may block the UI for three‑quarters of an hour before timing out, which is far longer than either the documented 15 minutes or the prior behaviour. Consider replacing the literal with 900000 for a true 15‑minute chat timeout and restoring a shorter default for regular tools so that broken evaluations fail promptly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants