Skip to content

ak/test new filters #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ak/test new filters #170

wants to merge 9 commits into from

Conversation

akoumjian
Copy link
Contributor

  • Added bvh orbit intersection and anomaly detection projections
  • fast query of observations against orbits (2-body)
  • progress towards labelling anomalies
  • fix typo
  • anomaly generation
  • working on fixing anomalies
  • closer to functioning anomalies
  • more good progress

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursor bot reviewed Sep 15, 2025
View reviewed changes
src/adam_core/geometry/bvh.py
concatenate(segments_chunks, defrag=True)
if segments_chunks
else segments_chunks[0]
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Empty List Access Causes Index Error

The build_bvh_index function encounters an IndexError when segments_chunks is empty. The conditional expression attempts to access segments_chunks[0] in its else branch, which is invalid for an empty list.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akoumjian