Bingj rebase #1448
Open
Bingj rebase #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perclass of EpsilonGreedy, and implemented option to weigh reward based on recency
…) so that it correctly calls update_rewards() through the parent method; all previous tests passed.
…dated doc test, and changed value of UNIFORM constant to -1.
Fix doctest, ++ stochastic strategies
|
Hi @bing-j, I rebased your PR after some recent fixes. All the test pass now, but there are a few lines uncovered by tests: 57, 59, and 74 in axelrod/strategies/bandits.py Once those are covered we should be good to add your strategies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1438, to see if all tests now pass.