Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/favorites/src/context/FavoritesProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,29 @@ const FavoritesContext = createContext<FavoritesContextType | null>(null);
export const FavoritesProvider = ({
children,
onFavoritesChange,
onMaxFavoritesReached,
applicationId = NAV_APP_ID,
maxFavorites = MAX_FAVORITES,
}: {
children: ReactNode;
onFavoritesChange?: (favorites: Favorite[]) => void;
onMaxFavoritesReached?: (favorites: Favorite[]) => void;
applicationId?: string;
maxFavorites?: number;

}): JSX.Element => {
const [lastClickedFavoriteId, setLastClickedFavoriteId] = useState<string>('');

const queryClient = useQueryClient();
const { data: favorites, status: queryStatus } = useFavoritesQuery(applicationId);

const { submitFavorites, status: mutationStatus } = useSubmitFavorites({
onMutationStart(targetFavoriteId) {
setLastClickedFavoriteId(targetFavoriteId);
const { submitFavorites, status: mutationStatus } = useSubmitFavorites(
{
onMutationStart(targetFavoriteId) {
setLastClickedFavoriteId(targetFavoriteId);
},
},
}, applicationId);
applicationId
);

useEffect(() => {
if (applicationId === NAV_APP_ID) {
Expand Down Expand Up @@ -87,6 +91,9 @@ export const FavoritesProvider = ({

if (favorites.length >= maxFavorites) {
openMaxModal(applicationId);
if (onMaxFavoritesReached && typeof onMaxFavoritesReached === 'function') {
await onMaxFavoritesReached(favorites);
}
return false;
}

Expand Down Expand Up @@ -129,7 +136,7 @@ export const FavoritesProvider = ({
};

// eslint-disable-next-line @typescript-eslint/no-empty-function
const noOp = () => { };
const noOp = () => {};

type MergedStatusUnion = 'initLoading' | 'reloading' | 'error' | 'success';
export const useFavorites = (
Expand Down
42 changes: 40 additions & 2 deletions packages/favorites/src/tests/FavoriteHeart.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ const setApplicationMock = jest.fn().mockResolvedValue({
},
});

const Providers = ({ children }) => (
const Providers = ({ children, ...rest }) => (
<QueryClientProvider client={queryClient}>
<Favorites>{children}</Favorites>
<Favorites {...rest}>{children}</Favorites>
</QueryClientProvider>
);

Expand Down Expand Up @@ -639,4 +639,42 @@ describe('FavoriteHeart', () => {

expect(heart).toBeDisabled();
});

test('should call custom onMaxFavoritesReachedHandler', async () => {
avSettingsApi.getApplication = jest.fn(() =>
Promise.resolve({
data: {
settings: [
{
favorites: maxFavorites,
},
],
},
})
);

const user = userEvent.setup();

const onMaxFavoritesReached = jest.fn();

const { container } = render(
<Providers onMaxFavoritesReached={onMaxFavoritesReached}>
<FavoriteHeart id="123" />
</Providers>
);

const heart = container.querySelector('#av-favorite-heart-123');

await waitFor(() => expect(heart).not.toBeChecked());

user.click(heart);

await waitFor(() => {
expect(avMessages.send).toHaveBeenCalledTimes(1);
expect(avMessages.send.mock.calls[0][0]).toBe('av:favorites:maxed');
expect(onMaxFavoritesReached).toHaveBeenCalledTimes(1);
});

await waitForPostMessageToSettle();
});
});
Loading