Skip to content

Conversation

bjnewman
Copy link
Contributor

Filtering all providers unless devs pass in searchAll prop.

@bjnewman bjnewman force-pushed the feat/provider-filter branch from 2045fac to 758f165 Compare January 10, 2024 19:27
@bjnewman
Copy link
Contributor Author

i forgot to account for the fact that parameters can be a function, will update the PR in a bit to address this

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aca08fd) 91.40% compared to head (ab9cf0d) 91.54%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
+ Coverage   91.40%   91.54%   +0.13%     
==========================================
  Files          20       21       +1     
  Lines         733      745      +12     
  Branches      243      245       +2     
==========================================
+ Hits          670      682      +12     
  Misses         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjnewman bjnewman marked this pull request as draft January 11, 2024 17:36
@bjnewman
Copy link
Contributor Author

converting to draft - it turns out that more internal discussion is needed before this change can be made ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant