Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions wpull/network/dns.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,16 +254,14 @@ def _query_dns(self, host: str, family: int=socket.AF_INET) \
try:
answer = yield from event_loop.run_in_executor(None, query)
except (dns.resolver.NXDOMAIN, dns.resolver.NoAnswer) as error:
# dnspython doesn't raise an instance with a message, so use the
# class name instead.
raise DNSNotFound(
'DNS resolution failed: {error}'
.format(error=wpull.util.get_exception_message(error))
.format(error=str(error))
) from error
except dns.exception.DNSException as error:
raise NetworkError(
'DNS resolution error: {error}'
.format(error=wpull.util.get_exception_message(error))
.format(error=str(error))
) from error
else:
return answer
Expand Down
13 changes: 0 additions & 13 deletions wpull/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,19 +202,6 @@ def close_on_error(close_func):
raise


def get_exception_message(instance):
'''Try to get the exception message or the class name.'''
args = getattr(instance, 'args', None)

if args:
return str(instance)

try:
return type(instance).__name__
except AttributeError:
return str(instance)


class PickleStream(object):
'''Pickle stream helper.'''
def __init__(self, filename=None, file=None, mode='rb',
Expand Down
40 changes: 1 addition & 39 deletions wpull/util_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from wpull.util import (datetime_str, python_version, filter_pem,
parse_iso8601_str, is_ascii, close_on_error,
get_exception_message, GzipPickleStream)
GzipPickleStream)


DEFAULT_TIMEOUT = 30
Expand Down Expand Up @@ -71,44 +71,6 @@ def oops(self):
self.assertRaises(ValueError, my_object.oops)
self.assertTrue(my_object.closed)

def test_get_exception_message(self):
self.assertEqual('oops', get_exception_message(ValueError('oops')))

try:
raise ValueError('oops')
except ValueError as error:
self.assertEqual('oops', get_exception_message(error))

self.assertEqual('ValueError', get_exception_message(ValueError()))

try:
raise ValueError
except ValueError as error:
self.assertEqual('ValueError', get_exception_message(error))

try:
raise ValueError()
except ValueError as error:
self.assertEqual('ValueError', get_exception_message(error))

self.assertEqual(
'NoNameservers', get_exception_message(NoNameservers())
)

try:
raise NoNameservers
except NoNameservers as error:
self.assertEqual(
'NoNameservers', get_exception_message(error)
)

try:
raise NoNameservers()
except NoNameservers as error:
self.assertEqual(
'NoNameservers', get_exception_message(error)
)

def test_pickle_stream_filename(self):
with tempfile.TemporaryDirectory() as temp_dir:
filename = os.path.join(temp_dir, 'blah.pickle')
Expand Down