-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add version bump and tag release workflows #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 0b4b182 in 1 minute and 11 seconds. Click for details.
- Reviewed
145
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/bump-version.yml:47
- Draft comment:
Consider anchoring the grep pattern (e.g. using '^current_version') to ensure you extract the correct version. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. .github/workflows/bump-version.yml:55
- Draft comment:
Similarly, anchor the grep pattern (e.g. '^current_version') when retrieving the new version for consistency. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. .github/workflows/bump-version.yml:36
- Draft comment:
Consider pinning the bump2version package version (e.g. bump2version==x.y.z) in the pip install command for build reproducibility. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. .github/workflows/tag-release.yml:33
- Draft comment:
Use an anchored grep pattern (e.g. '^current_version') here as well to ensure precise extraction of the version. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
5. .github/workflows/tag-release.yml:27
- Draft comment:
Consider pinning versions for dependencies (tox, twine, wheel, setuptools) to ensure reproducible builds. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_FC6lEK6htjcPAKn8
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
||
- name: Create Pull Request | ||
id: create_pr | ||
uses: peter-evans/create-pull-request@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: create_pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 90d6df2 in 48 seconds. Click for details.
- Reviewed
135
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
5
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/bump-version.yml:47
- Draft comment:
Consider adding error handling in case grep fails to find a valid version in .bumpversion.cfg. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
2. .github/workflows/bump-version.yml:54
- Draft comment:
Good use of a choice input for version_part. No additional sanitization needed since allowed values are enforced. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
3. .github/workflows/tag-release.yml:9
- Draft comment:
Ensure the label check (contains with github.event.pull_request.labels.*.name) behaves correctly when multiple labels are present. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. .github/workflows/tag-release.yml:42
- Draft comment:
Consider verifying that release.sh exists before applying chmod, to avoid potential job failures. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
5. .github/workflows/tag-release.yml:45
- Draft comment:
Consider capturing and logging output from release.sh to aid debugging if the PyPI publish step fails. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_0kKNvkeRTi5cwjxT
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
Adds GitHub Actions workflows for version bumping and tagging releases, automating version management and PyPI publishing.
bump-version.yml
to automate version bumping viabump2version
and create a pull request with updated version files.tag-release.yml
to tag releases on merged pull requests labeled withversion-bump
and publish to PyPI.bump-version.yml
allows bumpingmajor
,minor
, orpatch
versions and updatessetup.py
,docs/conf.py
,src/datapilot/__init__.py
, and.bumpversion.cfg
.tag-release.yml
creates a Git tag and pushes it to the repository, then executesrelease.sh
to publish to PyPI.This description was created by
for 90d6df2. You can customize this summary. It will automatically update as commits are pushed.