Refactor: Use Kotlin's Result type, Move SyncWork from presentation to data module and other misc actions #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the custom `Result` sealed class with Kotlin's built-in `kotlin.Result` type. This change simplifies the codebase by removing custom result handling and leveraging the standard library's implementation. All usages of the custom `Result` have been updated to use `kotlin.Result` and its associated functions like `isSuccess`, `isFailure`, `getOrNull`, `exceptionOrNull`, `map`, `onSuccess`, and `onFailure`.
The SyncWork class, responsible for background data synchronization, has been relocated from the `presentation` module to the `data` module. This change improves the separation of concerns by placing data-related operations within the appropriate module. Key changes: - Moved `SyncWork.kt` to `data/src/main/kotlin/com/aliasadi/data/workers/`. - Added a `LOG_TAG` constant in `SyncWork` for consistent logging. - Removed WorkManager dependency from `presentation/build.gradle.kts`. - Added WorkManager and Hilt dependencies to `data/build.gradle.kts` to support `SyncWork` and its Hilt injection.
mwshubham
changed the title
…not needed. The `MovieDataMapper.kt` file, which contained an extension function `toDbData()` to convert `MovieEntity` to `MovieDbData`, has been deleted.
It is required by com.aliasadi.data.util.NetworkMonitorImpl The `ACCESS_NETWORK_STATE` permission is added to the `AndroidManifest.xml` file. This allows the application to access information about networks.
The `safeApiCall` utility function has been removed. All usages of `safeApiCall` in `MovieRemoteDataSource` have been replaced with the standard Kotlin `runCatching` function.
mwshubham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commits for description