Skip to content

[ACS-10165] Move All Libraries page to ACA #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+33 −8
Open

[ACS-10165] Move All Libraries page to ACA #11240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions ...nents/search-filter-autocomplete-chips/search-filter-autocomplete-chips.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,24 +166,47 @@ describe('SearchFilterAutocompleteChipsComponent', () => {
});

it('should populate LOCATION field options with sites and predefined values from config', (done) => {
Copy link
Contributor Author

@g-jaskowski g-jaskowski Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason it treated an existing unit test that had one line changed as completely new code and newly added unit test as edited code

const sitesMock: SitePaging = {
list: {
pagination: {},
entries: [{ entry: { guid: 'site1', id: 'site1', title: 'Marketing', visibility: 'public' } }]
}
};
component.settings.field = AutocompleteField.LOCATION;
component.settings.autocompleteOptions = [{ value: 'Repository', query: `PATH:'somePath'` }];
spyOn(sitesService, 'getSites').and.returnValue(of(sitesMock));
component.onInputChange('mark');
component.autocompleteOptions$.subscribe((result) => {
expect(result).toEqual([
{ id: 'site1', value: 'Marketing' },
{ value: 'Repository', query: `PATH:'somePath'` }
]);
done();
});
});

it('should filter LOCATION field options', (done) => {
const sitesMock: SitePaging = {
list: {
pagination: {},
entries: [
{ entry: { guid: 'site1', id: 'site1', title: 'Marketing', visibility: 'public' } },
{ entry: { guid: 'site2', id: 'site2', title: 'Finance', visibility: 'private' } }
{ entry: { guid: 'site2', id: 'site2', title: 'Finance', visibility: 'moderated' } },
{ entry: { guid: 'site3', id: 'site3', title: 'HR', visibility: 'private' } },
{ entry: { guid: 'site4', id: 'site4', title: 'Legal', visibility: 'private', role: 'Consumer' } },
{ entry: { guid: 'site5', id: 'site5', title: 'IT', visibility: 'moderated', role: 'SiteManager' } }
]
}
};
component.settings.field = AutocompleteField.LOCATION;
component.settings.autocompleteOptions = [{ value: 'Repository', query: `PATH:'somePath'` }];
component.settings.autocompleteOptions = [];
spyOn(sitesService, 'getSites').and.returnValue(of(sitesMock));
component.onInputChange('mark');
component.autocompleteOptions$.subscribe((result) => {
expect(result).toEqual([
{ id: 'site1', value: 'Marketing' },
{ id: 'site2', value: 'Finance' },
{ value: 'Repository', query: `PATH:'somePath'` }
{ id: 'site4', value: 'Legal' },
{ id: 'site5', value: 'IT' }
]);
done();
});
Expand Down
10 changes: 6 additions & 4 deletions ...components/search-filter-autocomplete-chips/search-filter-autocomplete-chips.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,12 @@ export class SearchFilterAutocompleteChipsComponent implements SearchWidget, OnI
.pipe(
map((sites) => {
const predefinedOptions = this.settings?.autocompleteOptions || [];
const sitesOptions = sites.list.entries.map<AutocompleteOption>((siteEntry) => ({
id: siteEntry.entry.id,
value: siteEntry.entry.title
}));
const sitesOptions = sites.list.entries
.filter((siteEntry) => siteEntry.entry.visibility === 'public' || siteEntry.entry?.role)
.map<AutocompleteOption>((siteEntry) => ({
id: siteEntry.entry.id,
value: siteEntry.entry.title
}));
return [...sitesOptions, ...predefinedOptions];
})
)
Expand Down