-
Notifications
You must be signed in to change notification settings - Fork 341
fix: typo in docs/guide/installation.md #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @joplomacedo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a minor but important documentation fix. It corrects a typo in the installation guide, ensuring that the provided HTML example for including a stylesheet is accurate and free of errors. This change improves the clarity and correctness of the documentation for users.
Highlights
- Documentation Correction: Corrected a typo from "stylsheet" to "stylesheet" in the HTML link tag example within docs/guide/installation.md.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a typo in a stylesheet link within the installation documentation. While the fix is good, I've also suggested updating the version in the CDN URL to the latest major release, as it currently points to an outdated beta version. This will help ensure users are working with the most recent and stable version of the library.
@@ -71,7 +71,7 @@ Include `dist/floating-vue.min.js` in the page: | |||
Also include the default CSS: | |||
|
|||
```html | |||
<link rel="stylsheet" href="https://unpkg.com/floating-vue@^2.0.0-beta.1/dist/style.css" /> | |||
<link rel="stylesheet" href="https://unpkg.com/floating-vue@^2.0.0-beta.1/dist/style.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing the typo, I noticed that the CDN link points to a very old beta version (^2.0.0-beta.1
). According to the compatibility table in this document, version 5.x
is the latest for Vue 3. To avoid confusion and ensure users get the latest features and fixes, it would be better to update this link to point to the latest major version. A similar update should be applied to the script tag on line 68 for consistency.
<link rel="stylesheet" href="https://unpkg.com/floating-vue@^2.0.0-beta.1/dist/style.css" /> | |
<link rel="stylesheet" href="https://unpkg.com/floating-vue@^5/dist/style.css" /> |
stylsheet -> stylesheet