Skip to content

Improve ChunkCache #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve ChunkCache #761

wants to merge 2 commits into from

Conversation

@mapan1984
Copy link

@mapan1984 mapan1984 commented Oct 13, 2025 •
edited
Loading

Improve ChunkCache:

  1. fix Nested and repeated ExecutionException in ChunkCache.getChunk #760, remove future on exception
  2. If the future is in the cache, do not repeatedly wrap it with CompletableFuture.supplyAsync
  3. Remove redundant AtomicReference result

@mapan1984 mapan1984 requested a review from a team as a code owner October 13, 2025 11:19
@mapan1984 mapan1984 force-pushed the fix-issue-760 branch 2 times, most recently from 70d01b4 to 0664dc4 Compare October 13, 2025 11:21
mapan added 2 commits October 14, 2025 10:18
@mapan1984
fix(Aiven-Open#760): remove future on exception
5e8f4a0 
Change-Id: I9c876701b14b72d476f7a700465c05f6b870b5c1
@mapan1984
Improve ChunkCache
174dadd 
Change-Id: I9c876701b14b72d476f7a700465c05f6b870b5c1
@mapan1984 mapan1984 changed the title fix(#760): remove future on exception Improve ChunkCache Oct 14, 2025
@mapan1984
Copy link
Author

@ivanyu @juha-aiven @AnatolyPopov Hi, could you take a look at this PR when you have a moment? Thanks!

@AnatolyPopov AnatolyPopov self-requested a review October 14, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnatolyPopov AnatolyPopov Awaiting requested review from AnatolyPopov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested and repeated ExecutionException in ChunkCache.getChunk

1 participant

@mapan1984