Skip to content

Conversation

ssun0121
Copy link
Contributor

@ssun0121 ssun0121 commented Jan 19, 2024

ssun0121 and others added 25 commits November 23, 2023 20:32
…onEnabled and GetTokenIssuerAndOwnerModificationEnabled
Token contract supports the token issuer modifying the token's issuer and owner
…rAndOwnerModificationDisabled and adjust GetTokenIssuerAndOwnerModificationEnabled return value
Copy link

vizipi bot commented Jan 19, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 75 26
96.15% EanCuznaivy 433 25
80.77% ZhangXin 44 21
76.92% louis.li 48 20
76.92% eanzhao 41 20
69.23% gldeng 27 18

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...src/AElf.Kernel.SmartContract.ExecutionPluginForAcs1/FeeC75.00%3 out of 4 times

Committed file ranks

(click to expand)
  • 97.90%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 98.37%[...contract/AElf.Contracts.MultiToken/TokenContractConstants]
  • 98.76%[test/AElf.Contracts.Profit.Tests/ProfitTests.cs]
  • 99.77%[contract/AElf.Contracts.Profit/ProfitContract.cs]
  • 99.97%[protobuf/token_contract.proto]
  • 90.32%[...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe]
  • 99.04%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 97.45%[...test/AElf.Contracts.Election.Tests/Full/ReleaseProfitsFro]
  • 74.50%[...test/AElf.Contracts.Profit.Tests/ProfitContractTestConsta]
  • 94.40%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • @vizipi vizipi bot requested review from arg-foo, gldeng, jason-aelf and zhxymh January 19, 2024 03:43
    louis4li and others added 28 commits February 26, 2024 16:36
    …restriction
    
    feat:remove nft decimal restriction
    …d-chain' into feature/create-token-on-specified-chain
    …cified-chain
    
    Create token on specified chain
    …te-token-on-specified-chain
    
    # Conflicts:
    #	contract/AElf.Contracts.MultiToken/TokenContractConstants.cs
    …cified-chain
    
    Enhance compatibility with historical NFT creation
    @vizipi vizipi bot requested review from eanzhao and louis4li May 20, 2024 02:30
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants