Skip to content

Conversation

@isthaison
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 16, 2025 16:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the ESP32-P4-Function-EV-Board development board with Wi-Fi connectivity via ESP32-C6 co-processor and optional MIPI-DSI LCD display support.

Key changes:

  • Implementation of board-specific configuration and hardware abstraction layer
  • ESP-Hosted SDIO interface configuration for ESP32-C6 Wi-Fi connectivity
  • MIPI-DSI display support with detailed connection instructions

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdkconfig.defaults.esp32p4 Enables ESP-Hosted with SDIO configuration for ESP32-P4 target
main/boards/esp32-p4-function-ev-board/esp32-p4-function-ev-board.cc Board class implementation with dummy audio codec and no-display configuration
main/boards/esp32-p4-function-ev-board/config.json Build configuration specifying target and SDK config options
main/boards/esp32-p4-function-ev-board/config.h Hardware pin definitions and display/audio parameters
main/boards/esp32-p4-function-ev-board/README.md Documentation covering features, configuration, and LCD setup instructions
main/Kconfig.projbuild Adds new board type option to configuration menu
main/CMakeLists.txt Registers board type for build system

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@isthaison
Copy link
Contributor Author

image

@78
Copy link
Owner

78 commented Sep 18, 2025

Considering there's already an "ESP-S3-LCD-EV-Board-2," would the name "ESP-P4-Function-EV-Board" be more suitable?

@78
Copy link
Owner

78 commented Sep 19, 2025

@78
Copy link
Owner

78 commented Sep 26, 2025

@HonestQiao Check sdkconfig.defaults.esp32p4 if it works well for other P4 boards.

@HonestQiao
Copy link
Contributor

HonestQiao commented Oct 1, 2025

@HonestQiao Check sdkconfig.defaults.esp32p4 if it works well for other P4 boards.

  • Please note that CONFIG_ESP_HOSTED_P4_DEV_BOARD_FUNC_BOARD is a board-specific option, and should be set in config.json.
  • The remaining options are defaults and will be set automatically, so they should be removed from this file to avoid redundancy.

In my environment:

(base) ➜ [HonestQiao@cybertron] /Users/HonestQiao/Projects/ESP/xiaozhi-esp32 git:(df-p4-main) % grep -E 'CONFIG_ESP_HOSTED_ENABLED|CONFIG_ESP_HOSTED_P4_DEV_BOARD_FUNC_BOARD|CONFIG_ESP_HOSTED_SDIO_HOST_INTERFACE|CONFIG_ESP_HOSTED_SDIO_4_BIT_BUS' sdkconfig
CONFIG_ESP_HOSTED_ENABLED=y
# CONFIG_ESP_HOSTED_P4_DEV_BOARD_FUNC_BOARD is not set
CONFIG_ESP_HOSTED_SDIO_HOST_INTERFACE=y
CONFIG_ESP_HOSTED_SDIO_4_BIT_BUS=y

@78
Copy link
Owner

78 commented Oct 2, 2025

Yes. Here are my opinions:

  • The changes to the file sdkconfig.defaults.esp32p4 can be dropped.
  • The board folder can be renamed from esp32-s3-lcd-ev-board to esp-s3-lcd-ev-board to be consistent.
  • The touch function code is commented out. If it's not working, we should leave some comments.

Removed ESP hosted configuration options.
@78
Copy link
Owner

78 commented Oct 16, 2025

Since another PR #1243 has also modified the lcd_display.cc, please help resolve the conflicts and test if it still works.

And also address these points:

  1. The board folder can be renamed from esp32-s3-lcd-ev-board to esp-s3-lcd-ev-board for consistency.
  2. The touch function code is commented out. If it is not working, we should leave some comments explaining why.

@78 78 merged commit 6a4ec9d into 78:main Oct 24, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants