Error when using enterprise_slug

[joshblease]

I've just tried to use this module but added the enterprise slug parameter and ended up with this error:

Error: creating IAM Role (github): operation error IAM: CreateRole, https response error StatusCode: 400, RequestID: c8c0d8c3-58f2-4f71-9b17-b84fa3cf65e5, MalformedPolicyDocument: Trust policy with trusted principal arn:aws:iam::358411131270:oidc-provider/token.actions.githubusercontent.com/myslug/myslug must evaluate, using StringEquals, StringLike or StringEqualsIgnoreCase, token.actions.githubusercontent.com/myslug/myslug:sub which is not scoped to all.

I'll be proceeding without the enterprise slug for now but just thought I'd raise an issue.

[unfunco]

Thanks for reporting @joshblease – I no longer have access to an Enterprise GitHub instance but I'll look for a workaround soon.

[georgegeddes]

I experienced this bug as well. It looks like the enterprise slug is being added twice, but I'm not sure if that's the cause of the issue.

terraform-aws-oidc-github/data.tf

Line 40 in 6a67a48

identifiers = ["${local.oidc_provider_arn}%{if var.enterprise_slug != ""}/${var.enterprise_slug}%{endif}"]

terraform-aws-oidc-github/main.tf

Line 75 in 6a67a48

url = "https://token.actions.githubusercontent.com%{if var.enterprise_slug != ""}/${var.enterprise_slug}%{endif}"

I have access to an enterprise github and I would be willing to test a fix for this.