You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello everyone! 👋
I would like to gather community feedback about potentially renaming the ir_national_id validation rule (and its corresponding class IranianNationalId) back to ir_national_code (and class IranianNationalCode)in the next major version.
Background
In Persian language, we commonly use "کد ملی" (National Code) rather than "شناسه ملی" (National ID)
The term "National Code" was used in previous versions of this package
Many other Iranian packages and systems use "National Code" terminology
Current vs Proposed Names
Current:
Rule: ir_national_id
Class: IranianNationalId
Proposed:
Rule: ir_national_code
Class: IranianNationalCode
What Won't Change
The functionality will remain exactly the same
Only the naming will be affected
Backward compatibility will be maintained through deprecation notices
Questions for the Community
Please share your thoughts on:
Do you prefer national_code or national_id?
Would this change cause significant disruption to your projects?
Any other suggestions regarding the naming convention?
Your feedback will help us make the best decision for the community. Thank you for participating!
Note: If approved, this change would be implemented in the next major version release with proper deprecation notices to ensure smooth transition.
Should we rename `ir_national_id` back to `ir_national_code` in the next major version?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hello everyone! 👋
I would like to gather community feedback about potentially renaming the
ir_national_id
validation rule (and its corresponding classIranianNationalId
) back toir_national_code
(and classIranianNationalCode
)in the next major version.Background
Current vs Proposed Names
Current:
ir_national_id
IranianNationalId
Proposed:
ir_national_code
IranianNationalCode
What Won't Change
Questions for the Community
Please share your thoughts on:
national_code
ornational_id
?Your feedback will help us make the best decision for the community. Thank you for participating!
Note: If approved, this change would be implemented in the next major version release with proper deprecation notices to ensure smooth transition.
5 votes ·
Beta Was this translation helpful? Give feedback.
All reactions