Skip to content

"Add unsafe block" produces wrong syntax #20588

@lnicola

Description

@lnicola
    unsafe fn realloc(&self, ptr: *mut u8, _layout: Layout, new_size: usize) -> *mut u8 {
        { realloc(ptr.cast::<c_void>(), new_size) } as *mut u8
    }

// -> 

    unsafe fn realloc(&self, ptr: *mut u8, _layout: Layout, new_size: usize) -> *mut u8 {
        unsafe { realloc(ptr.cast::<c_void>(), new_size) } as *mut u8
    }

// should be

    unsafe fn realloc(&self, ptr: *mut u8, _layout: Layout, new_size: usize) -> *mut u8 {
        (unsafe { realloc(ptr.cast::<c_void>(), new_size) }) as *mut u8
    }

unsafe { f() } + 0 probably has the same issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions